search

orlikoski / Skadi

Collect, Process, and Hunt with host based data from MacOS, Windows, and Linux
https://www.skadivm.com
GNU General Public License v3.0
489 stars 71 forks source link

Fix AWS bugs #42

Closed jugalde closed 6 years ago

jugalde commented 6 years ago

tested with localstack (AWS mock server), and seems to be working

jugalde commented 6 years ago

ah now that you mention it, there does seem to be ambiguity in how the three params are used. In the case of reading from the bucket, writing locally, the 'src' isn't used at all. I'll make a fix to make that more clear.

jugalde commented 6 years ago

So my latest commit has my thoughts towards clearing up usage. I felt the clearest way to distinguish which is which (to or from s3), was to just separate out the functions. A bit more verbose, but I feel more clear. Lmk your thoughts.