Combined emoji (ZWJ) are being split

orling / grapheme-splitter

A JavaScript library that breaks strings into their individual user-perceived characters.

MIT License

926 stars 45 forks source link

Combined emoji (ZWJ) are being split #7

Closed Haroenv closed 7 years ago

Haroenv commented 7 years ago

🏳️‍🌈 is being split as ["🏳️‍", "🌈"]
🏃🏽‍♀️ is being split as ["🏃", "🏽‍", "♀️"]

keycap emoji like 8⃣ are correct

These should all be single emoji per character

orling commented 7 years ago

Thanks for pointing this out! The repo has been upgraded, you can use the latest index.js.

The npm package is still WIP as it is not under my account at the moment

DanCorder commented 7 years ago

I've just run into this issue. It's great that it's already fixed (and thank you for this excellent module, it's been a life-saver). Do you have an ETA for updating it on npm?

orling commented 7 years ago

The library is now in npm. Please note that it has a new package name ("grapheme-splitter" instead of "@ naytev/grapheme-splitter"). I'll make sure to keep the new one up-to-date whenever there is a new version

DanCorder commented 7 years ago

New NPM package is working great. Thanks again.