search

orlov-vo / parcel-transformer-svelte

Parcel 2 transformer for Svelte 3
https://www.npmjs.com/package/parcel-transformer-svelte
MIT License
40 stars 18 forks source link

Refactor, update deps, and add tests. #24

Closed gcoakes closed 2 years ago

gcoakes commented 2 years ago

I was having some issues with the transformer on the latest parcel version and decided to update a few things. It was failing on config.shouldReload(). I removed that, and proceeded to get a bit carried away... I touched most parts of the repo, so I understand if you don't want to take all the changes. However, I think the tests and shouldReload changes at the very least should be considered.

Please let me know if you want any or all of this. For now, I'm happy to just use my fork for my personal projects, so I understand if you reject this on the basis of it being too big of a change.

This change is Reviewable

orlov-vo commented 2 years ago

Thanks for your work! But, I can't accept / make good review of the PR with all-in-one changes at this time. Can you split your changes for separate PRs with fixes, refactoring, tests and updating deps?

gcoakes commented 2 years ago

I opened a PR (parcel-bundler/parcel#7508) to the parcel repo itself so svelte can be enabled by default in parcel. I also updated my personal version of this package to do typescript preprocessing out of the box. I don't intend to pursue this PR anymore.