search

orlyapps / nova-belongsto-depend

Larave Nova BelongsTo Field with Dependcy
MIT License
182 stars 65 forks source link

Support nova-tab #26

Closed CasperLaiTW closed 5 years ago

CasperLaiTW commented 5 years ago

Fix #25

PhilippeDirx commented 5 years ago

@CasperLaiTW Is there no way to generalise this? I'm having the same issue with https://github.com/eminiarts/nova-tabs And I'm certain similar situations will occur.

CasperLaiTW commented 5 years ago

Hi @PhilippeDirx

Actually I have no idea for supporting all scenarios

But in eminiarts/nova-tabs the TabsPanel extends Panel, so I think will not occur this issue.

I didn't test, but I will try :)

if you got error, maybe share the demo, screenshot or log to me I can try to reproduce.

https://github.com/eminiarts/nova-tabs/blob/master/src/TabsPanel.php#L8

PhilippeDirx commented 5 years ago

@CasperLaiTW Hey you're right, foolish me :') I did fork the repo myself and added a check for using availableFields function instead of fields function if it exists (appearently made to retrieve fields without tree structure).

Thanks for the info!