Closed dereklieu closed 9 years ago
How bout them apples.
It turns out that the province shapefiles contain ~33 cities that are also present in the municipality shapefile.
/admin/14130189000
returns Baguio city as well:
{"subregions":{"type":"FeatureCollection","properties":{"ID_0":177,"ISO":"PHL","NAME_0":"Philippines","ID_2_OR":14130000000,"NAME_2":"Benguet","ID_3_OR":14130189000,"NAME_3":"Baguio City","NL_NAME_3":null,"VARNAME_3":null,"TYPE_3":"Lungsod|Siyudad","ENGTYPE_2":"City","X_COORD":120.59425275800001,"Y_COORD":16.4048058757}
I will proceed to remove these from the province shapefiles, as they are redundant. We should do the same on the API side.
This should do it on the API side: https://github.com/developmentseed/openroads-api/blob/4329d93a7f5774c50e135db12fdac94f45a5be37/services/admin-subregions.js#L46
After import of the new shapefiles, the cities should not appear anymore. They were redundant polygons.
The above commit also merges the Shariff Kabusuan into Maguindanao. The former province was established in 2006 and abolished in 2008 again.
This guy made it into our region query (
/admin/
)Any idea why? It looks like a province to me.
@olafveerman @kamicut @anandthakker