search

orma / openroads-iD

Fork of iD to power Open Roads
Other
0 stars 0 forks source link

Feature/waytask state #96

Closed danielfdsilva closed 8 years ago

danielfdsilva commented 8 years ago

Depends on: https://github.com/opengovt/openroads-api/pull/122

olafveerman commented 8 years ago

Tried to test the iD part, but get stuck now on when saving an edit:

image

Can try to tackle this tomorrow morning. Any ideas @danielfdsilva ?

danielfdsilva commented 8 years ago

I am not able to replicate the problem. Can you give me all your steps? We can also try to work this out together.

olafveerman commented 8 years ago

Check out the branch. Run make & python simplehttpserver. I can start clean and do another attempt

olafveerman commented 8 years ago

@dereklieu Could you have a look at this PR? Have to focus on IFC proposal this morning.

dereklieu commented 8 years ago

@danielfdsilva I need to look at this more, but one enhancement I'd like to see is if we could hide the error box when there are no errors, instead of saying that they're all fixed? Or perhaps show it much smaller and grayed out. Something like:

screen shot 2016-04-13 at 9 13 28 am

[edit] although I think I'd prefer to see it hidden altogether. I also think the regular error display should be a bit more error-y, visually, to grab your attention more. As is, you wouldn't necessarily look to it at first when you selected a way.

danielfdsilva commented 8 years ago

@dereklieu Sure thing, that is not a problem. We should compile a list of all the enhancements, so then can be applied. I don't think hiding the errors is good UX, though. The user may be left wondering if they may be somewhere else.

dereklieu commented 8 years ago

@danielfdsilva sounds good. I'll put together a list this morning. And yeah I see your point about not hiding completely and think that's a good call.

dereklieu commented 8 years ago

Also trying to debug why I get a 500 error when trying to save to the currently deployed API on Heroku, which has the requisite route handler.

dereklieu commented 8 years ago

500 was this mispelling

dereklieu commented 8 years ago

@danielfdsilva ok, I fixed a few issues in other repos that were blocking this.

The last thing that remains to be done is to clean up the rendering code in waytask_list. To see the problem:

  1. Click a way that has no tasks.

screen shot 2016-04-13 at 6 06 20 pm

  1. Click on a way that has tasks.

screen shot 2016-04-13 at 6 06 44 pm

  1. Click back on the way that has no tasks.

screen shot 2016-04-13 at 6 07 02 pm

This is likely something to do with d3 enter/exit pattern.