Using EtherNetIP and Connection

ornl-epics / etherip

Java lib. for Ethernet/IP (AllenBradley ControlLogix, Compact Logix PLCs)

Eclipse Public License 1.0

111 stars 69 forks source link

Using EtherNetIP and Connection #36

Closed aaron-bru closed 3 years ago

aaron-bru commented 3 years ago

Hello, I need to be able to use the EtherNetIP class, as well as its underlying Connection, specifically the execute() and getSession() methods. I'm using a simple accessor, but I'm happy to submit a different pull request. Some ideas are:

getConnection() accessor
exposing execute() and getSession() in EtherNetIP
Adding a dependency injection constructor or initializer to allow passing in a Connection object

Thanks

kasemir commented 3 years ago

Adding an accessor like getConnection() is fine, please go ahead with PR.