search

ornl-epics / etherip

Java lib. for Ethernet/IP (AllenBradley ControlLogix, Compact Logix PLCs)
Eclipse Public License 1.0
112 stars 69 forks source link

Add to CNService enum #37

Closed aaron-bru closed 3 years ago

aaron-bru commented 3 years ago

Hello, I need to add some values to the CNService enum, I'm not sure if this is something you'd want merged in or not. If so the ones I need are ForwardOpen(0x54) and ForwardClose(0x4E) which I can submit.

Alternatively, I've read the easiest way to allow adding at runtime is to have the enum implement an interface which is used throughout the library, which other applications can then implement as needed. I don't mind attempting this if it's preferred.

kasemir commented 3 years ago

Adding those values is fine, please go ahead with PR.