search

ornl-epics / pvws

PV Web Socket: Channel Access, PV Access, simulated PVs, ... via a ws://
BSD 3-Clause "New" or "Revised" License
21 stars 15 forks source link

Add the core-formula to allow pv formulas #10

Closed shroffk closed 2 years ago

shroffk commented 2 years ago

While not perfect, this can help avoid a lot of scripts

image

kasemir commented 2 years ago

Great.. but I don't understand how this works. You just added a dependency to core-formula. But there is already a dependency to core-pv, which in turn depends on core-formula:

https://github.com/ControlSystemStudio/phoebus/blob/c1d8b05ba639895968844813458f4941908b4936/core/pv/pom.xml#L54

So is this redundant? Or might actually cause a problem, because instead of simply using whatever version of core-formula is requested by core-pv, we're potentially asking for a different one?

kasemir commented 2 years ago

In fact just tried the latest "master" without this change to the pom, and formula already works:

Screen Shot 2022-06-06 at 10 40 29 AM
kasemir commented 2 years ago

What we might need soon is another release of phoebus so you don't have to build the local snapshot to get the latest core-pv & core-pva

shroffk commented 2 years ago

Oh... If core-pv depends on core-formula then my change is indeed not required.

+1 on the new release... We have almost completed the elastic 8 upgrade to the services too ( need to fix the logging ui app ) so we should that should justify a new release too.