search

ornladios / ADIOS

The old ADIOS 1.x code repository. Look for ADIOS2 for new repo
https://csmd.ornl.gov/adios
Other
54 stars 40 forks source link

Skel lib: Python3 #178

Closed ax3l closed 6 years ago

ax3l commented 6 years ago

Transform the python scripts in utils/skel/lib with 2to3 to be python3 compatible.

ax3l commented 6 years ago

@pnorbert can you please check if still everything works as expected in Python 2.7?

pnorbert commented 6 years ago

Hi Axel, I am at IPDPS at the moment. @jychoi-hpc https://github.com/jychoi-hpc @isosc If you have some time this week, can you please check this PR? Thanks Norbert

On Wed, May 23, 2018 at 12:56 PM, Axel Huebl notifications@github.com wrote:

@pnorbert https://github.com/pnorbert can you please check if still everything works as expected in Python 2.7?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ornladios/ADIOS/pull/178#issuecomment-391422462, or mute the thread https://github.com/notifications/unsubscribe-auth/ADGMLfS4Alefzyhk27_a3D8lfZIl9GADks5t1ZTGgaJpZM4UKzoA .

ax3l commented 6 years ago

@jychoi-hpc @isosc can you please take a look at this PR? :-)

jychoi-hpc commented 6 years ago

Sorry for being late. I am not knowledgeable to check this. I think Jeremy probably can do this.

On Jun 4, 2018, at 10:18 AM, Axel Huebl notifications@github.com wrote:

@jychoi-hpc @isosc can you please take a look at this PR? :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

isosc commented 6 years ago

@ax3l , I'm not sure this will work as is. I was under the impression that the Cheetah library that skel depends on is Python 2 only. I think there is a Python 3 fork from industry, but I don't recall the name. Does the converted code still work with Python 2?

What is driving this change to Python 3?

Thanks, Jeremy

ax3l commented 6 years ago

Hi Jeremy, I discovered the issue when trying to install ADIOS in a python3 only environment.

Maybe problem was caused by the ad_config.py file I also patched, but updating the other syntax as well is already a step forward - even if not all dependencies support Python3 yet. (Still works under Python2 anyway.)

isosc commented 6 years ago

Sounds good, thanks!