Numpy Wrapper: OSX - Githubissues

ornladios / ADIOS

The old ADIOS 1.x code repository. Look for ADIOS2 for new repo

https://csmd.ornl.gov/adios

Other

54 stars 40 forks source link

Numpy Wrapper: OSX #179

Closed ax3l closed 6 years ago

ax3l commented 6 years ago

-lrt is not available on OSX (Darwin).

Actually it only needs to be added to pre-2013 glibc libs... Anyway, just append it on Linux now.

Note

Can be merged now.

[x] I am still trying to confirm this fixes OSX builds... https://github.com/conda-forge/staged-recipes/pull/5932 -> works!

ax3l commented 6 years ago

@pnorbert @jychoi-hpc @isosc here is another fix for your consideration :)

jychoi-hpc commented 6 years ago

I have no Windows environment to test this. But, I tested on my mac and it works.

ax3l commented 6 years ago

That's good, it is only a fix for OSX. the ifneq for Windows just avoids that if someone experiments with windows it will not explode by calling a shell with uname.

ax3l commented 6 years ago

@jychoi-hpc any update on the PR? can this be merged?

jychoi-hpc commented 6 years ago

I think it's good to be merged. Norbert, can you merge?

On Jun 4, 2018, at 10:17 AM, Axel Huebl notifications@github.com wrote:

@jychoi-hpc any update on the PR? can this be merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ax3l commented 6 years ago

@isosc cc here :)