search

ornladios / ADIOS

The old ADIOS 1.x code repository. Look for ADIOS2 for new repo
https://csmd.ornl.gov/adios
Other
54 stars 40 forks source link

serial adios_open with parallel lib #182

Closed ax3l closed 6 years ago

ax3l commented 6 years ago

Fix a runtime error in the following situation:

when a user compiles a serial program against the parallel ADIOS libs, there are two ways to use ADIOS without the need to start the app with mpiexec:

a) use the moc library instead b) pass MPI_COMM_NULL as communicator

I need the last case in my application but still adios_open calls a single MPI_Comm_rank which aborts the application.

This check (as it is done in many other places) fixes it.

ax3l commented 6 years ago

@pnorbert if you plan a 1.13.2 bugfix release, this PR together with #179 and #178 would be much appreciated :-)

ax3l commented 6 years ago

oh there are more locations. will open another PR soon. update: hm, that's a lot of MPI_File_ calls where we would have to do RT switches to the dummy lib if the comm is MPI_COMM_NULL...