search

ornladios / ADIOS

The old ADIOS 1.x code repository. Look for ADIOS2 for new repo
https://csmd.ornl.gov/adios
Other
54 stars 41 forks source link

Possible bug in bp2ncd utility #205

Open khou2020 opened 4 years ago

khou2020 commented 4 years ago

Hi:

I found some strange code in the bp2ncd utility. In line 407 of np2ncd.c if (i==var_dims_count) { I can't find where variable "i" is initialized. Should it be included in the else clause on line 376?

pnorbert commented 4 years ago

You are right, something is illogical there. I would assume there should be an i = 0; after line 359 because the true branch starting at line 360 does not set i. The false branch does with the for loop.