search

ornladios / ADIOS

The old ADIOS 1.x code repository. Look for ADIOS2 for new repo
https://csmd.ornl.gov/adios
Other
54 stars 41 forks source link

Numpy: Significant parts of the adios api are missing #91

Open cstatz opened 8 years ago

cstatz commented 8 years ago

Dear Adios Developers;

I hope I did not miss an important point (and I would be grateful for a pointer in the right direction), but it seams significant parts of the adios api are missing in the numpy wrappers.

Specifically all "interesting" adios.define_ that make it useful for visualization purposes such as:

Without this functionality the "noxml variant" of adios is not sufficiently usable from python. Is it planned to wrap these functions in the near future?

BR, C.

cstatz commented 8 years ago

I've added the missing parts. How would you like to have the changeset? Is a pull request okay?

jychoi-hpc commented 8 years ago

Thank you for the update. I checked the new code looks ok and compiling goes without any problem. However, I don't know how to test. Do you have any test code? Can you create a unit test code like ones in "test" directory? If you can share your test case, I can test and write one too.

Jong

jychoi-hpc commented 8 years ago

I mean "test" directory in "wrappers/numpy" directory, not in the root.

cstatz commented 8 years ago

;) I've got it. I'll prepare what I have and send you the files ...

BR, C.

Dipl.-Ing. Christoph Statz Wissenschaftlicher Mitarbeiter

Technische Universität Dresden Institut für Nachrichtentechnik Lehrstuhl Hochfrequenztechnik Helmholtzstr. 18 01062 Dresden

Tel: 0351 - 463 32287 Fax: 0351 - 463 37163 Email: christoph.statz@tu-dresden.de mailto:christoph.statz@tu-dresden.de

Am 13.10.2016 um 16:37 schrieb Jong Choi notifications@github.com:

I mean "test" directory in "wrappers/numpy" directory, not in the root.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ornladios/ADIOS/issues/91#issuecomment-253532366, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhYu4QBagcvIlWIxn_u1xuiNYpYkf6qks5qzkI9gaJpZM4KVAyQ.

cstatz commented 8 years ago

@yyalli How do you like me to provide the test code? Should I issue another pull-request?

jychoi-hpc commented 7 years ago

Sorry for the late reply. Can you add in the pull request branch?