search

ornladios / ADIOS2-Examples

Application examples for the ADIOS2 I/O library https://github.com/ornladios/ADIOS2. This is Work in Progress.
Apache License 2.0
20 stars 16 forks source link

python 3 syntax #33

Open dmitry-ganyushin opened 4 years ago

dmitry-ganyushin commented 4 years ago

in gsplot.py raise "abc"
probably is not a valid python 3 syntax

williamfgc commented 4 years ago

@dmitry-ganyushin welcome! Please feel free to start contributing. I don't have a CI for Python3 components. It just verifies that C and C++ executables build and run.

dmitry-ganyushin commented 4 years ago

Thanks, William. I will clean-up python files and check them with pylint.

williamfgc commented 4 years ago

@dmitry-ganyushin thanks! Do you think there is a way to put pylint on CI? The build.sh is run on azure just to make sure the library builds and installs.

dmitry-ganyushin commented 4 years ago

Sure, there is a way to check it in CI. Another possibility is to check it before commit. What would you prefer?

dmitry-ganyushin commented 4 years ago

There is a way to define an action on github which should check python files with pylint after every push. You do not have to wait for a big build on azure just to check python syntax.

williamfgc commented 4 years ago

I'd check with @pnorbert , I just added azure-pipelines as it predates GitHub Actions. Feel free to add what makes more sense.

pnorbert commented 4 years ago

@chuckatkins is using both (and travis) in the adios2 repository. So use whichever you think is better.

chuckatkins commented 4 years ago

Formatting checks are run on Travis with clang-format for the c++ code and flake8 for the Python code and is executed immediately on push. We can certainly add pylint to that.

chuckatkins commented 4 years ago

In the adios2 repo we use a combination of Travis, circle, azure pipelines, and GitHub actions, each for different use cases, in order to maximize our throughout and not get ci backlogs during times of high activity.