search

orocos-toolchain / ocl

Orocos Component Library
Other
16 stars 33 forks source link

deployment: accept name "this" as an alias for the DeploymentComponent in arguments #42

Closed meyerj closed 8 years ago

meyerj commented 8 years ago

Because the DeploymentComponent overrides the loadService operation and the name of the deployer might not be known, the operations which translate a string into a TaskContext should accept "this" as an alias for the DeploymentComponent itself. This is in line with the usage of the "this" keyword in RTT scripting.

Use case:

import("rtt_rosdeployment")
loadService("this", "rosdeployment")
ahoarau commented 8 years ago

Is this gonna be merged into 2.8 ?

meyerj commented 8 years ago

I do not see a reason why this commit should not be merged into 2.8 as it does not break ABI compatibility and only extends the deployer's operation interface in a backwards compatible way (unless someone loaded a component named "this", which would be a very bad practice anyway).

snrkiwi commented 8 years ago

Seems like a reasonable enough change.