orocos-toolchain / ocl

Orocos Component Library
Other
16 stars 33 forks source link

Prevent double-configure issues when checking deployments #55

Closed snrkiwi closed 7 years ago

snrkiwi commented 7 years ago

The existing "check" approach calls loadComponents(file), which loaded all components from "file" into the next group, and then called configureComponents(), which configured all groups. This results in configuring components in some layers multiple times, if multiple files are loaded. e.g.

results in

The fix is to use the internal load/configure/start functions that know about groups, and which only load/configure/start the components of the current group. This effectively needs a kickStart() that knows whether the user wants to start components or not (which is the only net difference between a deployment run with and without checking.

meyerj commented 7 years ago

Looks good to me.

meyerj commented 7 years ago

Any reason not to merge this into master or toolchain-2.8? The patch is fully API- and ABI-compatible and fixes a broken behavior.