orocos-toolchain / ocl

Orocos Component Library
Other
16 stars 33 forks source link

taskbrowser: cd command autocompletion #6

Closed jbohren closed 10 years ago

jbohren commented 10 years ago

It seems like after a recent change, the cd command no longer autocompletes by component name. Was that intentional or a side-effect of something else?

smits commented 10 years ago

I can reproduce this:

Deployer [S]> loadComponent("One","TaskContext")
 = true                

Deployer [S]> loadComponent("Two","TaskContext")
 = true                

Deployer [S]> cd <TAB>
One  Two  
Deployer [S]> cd On <TAB>
<nothing happens>
smits commented 10 years ago

I found the source:

commit 4ab57c5a adds the following check in findPeer:

1093           if ( !pp.foundPath() ) {
1094                    log(Debug) <<"No such peer : "<< c <<endlog();
1095                    return 0;
1096            }

Which disables autocomplete on ls and cd (see line 281 where it forces an early return). @psoetens why was this added?

psoetens commented 10 years ago

Just remove it again and see if it breaks anything...

smits commented 10 years ago

closed by cd53c80