search

orocos-toolchain / ocl

Orocos Component Library
Other
16 stars 33 forks source link

deployment:: implement GlobalsRepository Properties parsing #63

Closed MagnaboscoL closed 5 years ago

MagnaboscoL commented 7 years ago

This PR implements the parsing of the GlobalService Properties.

TODO:

meyerj commented 6 years ago

TODO:

expose GlobalService Properties to TaskContext expose GlobalService Properties to scripting

What exactly was meant by this?

meyerj commented 5 years ago
  • [ ] expose GlobalService Properties to TaskContext

Global properties could be included as a fall-back when looking up properties using tc->getProperty(name), but it would be inconsistent to the result of tc->properties()->getProperty(name) which is a method of RTT::PropertyBag and not specific to TaskContext.

I suggest to not change the TaskContext implementation. C++ users can lookup/update global properties explicitly by accessing RTT::types::GlobalsRepository::Instance().

  • [ ] expose GlobalService Properties to scripting

Did you actually mean GlobalsRepository properties?

For scripting, global properties should be handled in the same way as global attributes/constants. This is already part of https://github.com/orocos-toolchain/rtt/pull/218. With that patch to RTT::scripting::ValueParser the "hack" (https://github.com/orocos-toolchain/ocl/pull/63/#discussion_r147844436) is obsolete.

meyerj commented 5 years ago

For scripting, global properties should be handled in the same way as global attributes/constants. This is already part of orocos-toolchain/rtt#218. With that patch to RTT::scripting::ValueParser the "hack" (#63) is obsolete.

Done in https://github.com/orocos-toolchain/ocl/pull/63/commits/5ac97397108f8474847429dd3cdfb02af031b1c4.