Fix using_task_library dependency resolution

[hemker]

When using a "separate prefixes" build configuration, included headers from a "using_task_library" dependency were not found. I am not 100% sure whether my fix is totally correct to fix the problem, but as far is I understood the used_task_libraries member of the project was never used to generate the task's dependencies in that specific case, so I added them.

[doudou]

Hi @hemker

Could you maybe give us a specific error you are getting ? I am not sure what`s the actual issue.

Just to frame the discussion: what the current code is doing is only include task libraries that are actually used (the two lines before your change) - whether this is a good thing is arguable.

[hemker]

Hey @doudou I just provided a test case to reproduce the problem. In the test module dependent_includes you can find the include #include <cross_consumer/TaskStates.hpp>. The provided test case fails (because the header is not found) without having the extra line in project.rb.

[doudou]

So, I really can`t find a good reason why your change would be bad. And there's definitely a good reason for it...

Just implement the one small change in my review, and create the test package(s) separately. Name them over what they are testing, for instance build_tests/orogen/using_task_library-not_picking_up_not_directly_used_dependencies-publisher and build_tests/orogen/using_task_library-not_picking_up_not_directly_used_dependencies-consumer. And refer to the bug in the buildconf commit.

[hemker]

@doudou Did all required steps.

[hemker]

@doudou Still anything to do here?

[doudou]

My apologies @hemker ... I'm on it now