search

orocos-toolchain / orogen

Code generator for components and type handling in Rock - the Robot Construction Kit - and the Orocos Toolchain
http://rock-robotics.org
Other
4 stars 35 forks source link

Proxies patch #35

Closed jmachowinski closed 9 years ago

jmachowinski commented 9 years ago

Hey, here the merge request. This code is currently still based on rock1408. I will rebase it if there are no further comments on it.

jmachowinski commented 9 years ago

Updated the ruby code. What is the preferred mechanism for optional stuff, env variable ?

doudou commented 9 years ago

Updated the ruby code. What is the preferred mechanism for optional stuff, env variable ?

Flags and command-line options. See for instance the handling of the extended-states flag in bin/orogen

jmachowinski commented 9 years ago

Updated code according to comments

jmachowinski commented 9 years ago

Next round

jmachowinski commented 9 years ago

Any more comments, or can I rebase on master ?

doudou commented 9 years ago

You can rebase. The last comment will be about orocos_cpp_base being C++11, but that should be on rock-dev

jmachowinski commented 9 years ago

closing this pr and recreating the final one

doudou commented 9 years ago

Better to update existing PRs by pushing the new code to the PR branch ... This keeps the comments around, which is great when questions arise.

jmachowinski commented 9 years ago

The proxies branch is in use. I can't update it.