search

orocos-toolchain / rtt

Orocos Real-Time Toolkit
http://www.orocos.org
Other
72 stars 79 forks source link

boost 1.61 support #192

Closed planthaber closed 7 years ago

planthaber commented 7 years ago

Partial Function Template Ordering was removed from boost in 1.59, the according define BOOST_PFTO also.

I am not really sure if the define is the correct way to solve it, bur at lease the functionality doesn't change for users with older boost versions

Also changed some ifdefs, from checking against 1.62 to 1.61 (current default in ubuntu 16.10)

I wonder how it compiled against 1.62 before, somebody might have done it as the boost::serialization::array_wrapper defines were already here

meyerj commented 7 years ago

The guard for the renamed boost::serialization::array_wrapper<T> template class has been introduces recently in https://github.com/orocos-toolchain/rtt/commit/87659188c71bf3013247590a386321648dd8fb67. You are right that the check should have been against Boost 1.61 instead. Could you please also update the remaining check in mqueue_archive_test.cpp:111?

We tested the patch for the Max OS X target with Boost 1.63 and Xcode 7.3 and 8.2 in Travis: https://travis-ci.org/orocos-toolchain/orocos_toolchain/builds/187551156. There was no error due to the undefined BOOST_PFTO macro for some reason.

planthaber commented 7 years ago

Updated the PR

The boost/ptfo.hpp header is completely removed from boost. Anyways checking #ifndef BOOST_PFTO is still the better solution.

Also fixed the test case guard for mqueue_archive_test.cpp:111

meyerj commented 7 years ago

Thanks!