search

orocos-toolchain / rtt

Orocos Real-Time Toolkit
http://www.orocos.org
Other
72 stars 79 forks source link

Fix/create properly OrbRunner activity #216

Closed MagnaboscoL closed 7 years ago

MagnaboscoL commented 7 years ago

In TaskContextServer.cpp#L342 the cpu_affinity is passed as third argument and this way the compiler chooses to use the constructor in Activity.hpp#L141 where the third argument is the period (double).

This PR proposes also a naming convention for the Threads created by RTT itself. For the moment the new naming convention is used only for the OrbRunner Thread.

@meyerj PTAL

PS If preferred I could rebase the PR on master.

meyerj commented 7 years ago

Looks good to me. Thanks!

I am not aware of a written down policy regarding commit messages (@psoetens?), but it is common to sign off commits within RTT and OCL (using git commit -s). I also typically prefix commit messages with a short keyword or path, e.g. engine:, os: or corba: in this case, but that is probably a matter of taste. Ideally the commit message also contains the full explanation/motivation of the patch if it is not obvious, because it is much easier to search and also available in the local history without having to depend on a specific Git service provider like GitHub. I usually copy the exact same text to the pull request afterwards.

MagnaboscoL commented 7 years ago

This PR is closed since Internal RTT Threads used by OrbRunner and CorbaDispatcher should also be parametrized as proposed in PR218.