meyerj
commented
5 years ago We did not change something deliberately. No patches are applied to the debian/rules file generated by bloom.
Indeed I see that the latest release does not add the -DCATKIN_BUILD_BINARY_PACKAGE="1" cmake variable anymore in debian/rules.em:
--- a/debian/rules.em
+++ b/debian/rules.em
@@ -8,7 +8,6 @@
# Uncomment this to turn on verbose mode.
export DH_VERBOSE=1
-export DH_OPTIONS=-v --buildsystem=cmake
# TODO: remove the LDFLAGS override. It's here to avoid esoteric problems
# of this sort:
# https://code.ros.org/trac/ros/ticket/2977
@@ -20,17 +19,14 @@ export PKG_CONFIG_PATH=@(InstallationPrefix)/lib/pkgconfig
export DEB_CXXFLAGS_MAINT_APPEND=-DNDEBUG
%:
- dh $@@
+ dh $@@ -v --buildsystem=cmake
override_dh_auto_configure:
# In case we're installing to a non-standard location, look for a setup.sh
# in the install tree that was dropped by catkin, and source it. It will
# set things like CMAKE_PREFIX_PATH, PKG_CONFIG_PATH, and PYTHONPATH.
if [ -f "@(InstallationPrefix)/setup.sh" ]; then . "@(InstallationPrefix)/setup.sh"; fi && \
- dh_auto_configure -- \
- -DCATKIN_BUILD_BINARY_PACKAGE="1" \
- -DCMAKE_INSTALL_PREFIX="@(InstallationPrefix)" \
- -DCMAKE_PREFIX_PATH="@(InstallationPrefix)"
+ dh_auto_configure -- -DCMAKE_INSTALL_PREFIX="@(InstallationPrefix)"
override_dh_auto_build:
# In case we're installing to a non-standard location, look for a setup.shrtt specifies <export><build_type>cmake</build_type></export> in its package.xml because it is not a catkin-package and needs to be installed. But it tries to find catkin in its CMakeLists.txt to install an env-hook and also installs the package.xml in CMakeLists.txt:174.
Apparently since https://github.com/ros-infrastructure/bloom/pull/435 it is not allowed to call find_package(catkin) in a package with build-type cmake? Also note that the cmake/template.spec.em for generating rpms from cmake packages added in the same bloom PR still has the catkin-specific -DCATKIN_BUILD_BINARY_PACKAGE="1" option, so this issue only affects Debian-based targets.
I will add a patch to readd the -DCATKIN_BUILD_BINARY_PACKAGE="1" cmake option to rules.em.
tfoote
@meyerj This appears to be causing a regression for downstream packages: http://build.ros.org/view/Kbin_uX64/job/Kbin_uX64__ocl__ubuntu_xenial_amd64__binary/6/console
It seems to be trying to install the setup files that are usually disabled for the debian packages except for catkin. Are the default debian rules being overridden?
relevant rosdistro release: https://github.com/ros/rosdistro/pull/21232