search

orocos-toolchain / utilrb

A small set of useful Ruby classes and extensions
Other
2 stars 13 forks source link

make flexmock a test dependency #25

Closed doudou closed 9 years ago

doudou commented 9 years ago

@smits: will test_depend be simply ignored by the ROS build stuff, or will it cause a problem ?

doudou commented 9 years ago

Ping @smits

meyerj commented 9 years ago

I verified this in ROS indigo and Ubuntu trusty and this patch does not seem to cause problems. Unknown tags like <depend_optional> and <test_depend> are obviously ignored by rosdep/rospkg.

Only package names in <rosdep name="..."/> and <depend package="..."/> must be either known to the rosdep database or findable in the ROS_PACKAGE_PATH, respectively, for rosdep and other ROS tools to work, which in turn is required for releases in the ROS ecosystem. (manifest.xml is deprecated in ROS, but if it exists, it must be valid and is preferred for retrieving dependencies.)

The flexmock package is known to rosdep, so it could also be added to utilrb/package.xml, where <test_depend> is a known tag. package.xml does not make a difference between system dependencies and other ROS packages.

ROS manifest.xml specs: http://docs.ros.org/independent/api/rospkg/html/manifest_xml.html#manifest-xml ROS package.xml specs: http://www.ros.org/reps/rep-0127.html

Tested versions:

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                                  Version                                             Architecture Description
+++-=====================================================-===================================================-============-==============================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================
ii  python-rosdep                                         0.11.2-1                                            all          rosdep package manager abstrction tool for ROS
ii  python-rospkg                                         1.0.35-1                                            all          ROS package library
doudou commented 9 years ago

Thanks @meyerj. rosdep tracks the debian packages for flexmock, and utilrb requires flexmock 2.0 which got just released.