orocos / orocos-bayesian-filtering

The orocos Bayesian Filtering Library
148 stars 59 forks source link

correct pkgconfig include directory? #43

Open josch opened 6 years ago

josch commented 6 years ago

Hi,

in the orocos-bfl.pc it says:

includedir=${prefix}/include

But with that value, the examples will not build outside of the source directory because they are not including the bfl component in the header include path. So my question is:

Is the source code shown in the example directory supposed to be real-world code examples?

If yes, they should either either:

toeklk commented 6 years ago

Hmm, That's a difficult one. Right now the examples seem (i.e. I'm not the original author) to have been created for 2 main purposes:

I follow your concern, and I would prefer the first suggestion, yet I think that will break the compilation of the tests. I do see the advantage of reusing the code from the examples in the tests, but there's definitely also a downside to this which you revealed now.