orocos / orocos-bayesian-filtering

The orocos Bayesian Filtering Library
148 stars 59 forks source link

Only check for approximate equality in matrixwrapper's determinant test #50

Closed morxa closed 6 years ago

morxa commented 6 years ago

This fixes an issue similar to #11 that also only occurs on i686.

toeklk commented 6 years ago

Thx Till! When you say 'similar', I suppose this patch doesn't fix #11 itself, right?

morxa commented 6 years ago

So the error in #11 was caused by the same problem: Rounding on i686 was wrong and it failed comparisons of doubles that were almost equal. The test case in #11 does not fail anymore, so I think it can be closed.