search

orocos / orocos_kinematics_dynamics

Orocos Kinematics and Dynamics C++ library
702 stars 408 forks source link

Export modern CMake interface target #366

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Original pull request on ROS 2 fork: https://github.com/ros2/orocos_kinematics_dynamics/pull/14

MatthijsBurgh commented 3 years ago

@meyerj @smits any objections for this one?

meyerj commented 3 years ago

@meyerj @smits any objections for this one?

The declared minimum CMake version is still 2.6 according to orocos_kdl/CMakeLists.txt, which like was already outdated before. I have no objections against using modern CMake in KDL, but then I suggest to also update the cmake_minimum_required() statement to 3.0.2, like in python_orocos_kdl/CMakeLists.txt (https://github.com/orocos/orocos_kinematics_dynamics/pull/297). That also makes the checks of policy CMP0048 obsolete because cmake_minimum_required(VERSION ...) sets all policies introduced earlier to NEW internally.

MatthijsBurgh commented 3 years ago

@meyerj I updated the minimum cmake version.