search

orocos / orocos_kinematics_dynamics

Orocos Kinematics and Dynamics C++ library
671 stars 407 forks source link

Add accessors #419

Closed Masa0u0 closed 1 year ago

Masa0u0 commented 1 year ago

Hello. I am a university student in Japan. I propose the following two things

orocos_kdl will be easier to use. Please consider.

MatthijsBurgh commented 1 year ago

I will have to check which changes are ABI compatible. As these are small changes, 8 don't want to break ABI compatibility for it.

Masa0u0 commented 1 year ago

@MatthijsBurgh Thank you for your comments. Could you tell me what I should do?

Masa0u0 commented 1 year ago

@MatthijsBurgh I updated PR. Please check again.

MatthijsBurgh commented 1 year ago

@Masa0u0 These are the only ABI compatible changes.

Masa0u0 commented 1 year ago

@MatthijsBurgh I understand. I am disappointed that TreeFkSolverPos_recursive and TreeJntToJacSolver cannot have the const reference of Tree.

MatthijsBurgh commented 1 year ago

@Masa0u0 could you add missing docstring to the added function in Segment. I have no idea what a good docstring would be.

Masa0u0 commented 1 year ago

@MatthijsBurgh I changed the name of the added function and added docstring to it. I'm sorry, I made a mistake in the commit messages.