meyerj
commented
4 years ago Thanks! In general, the manifest.xml files are also used by another build tool used by the Rock community, Autoproj. The incompatibility with rosdep and diverged specification is a known and long lasting issue:
- https://github.com/orocos-toolchain/utilrb/issues/5
- https://github.com/orocos-toolchain/rtt/pull/321#issuecomment-630919573
I am not aware of someone using rtt_soem with Autoproj and also did not find any hints with Google. So I am fine with removing old files related to rosbuild. If needed, we can still restore and update them.
Could you please remove all manifest.xml files, but also Makefile, mainpage.dox and the top-level stack.xml and CMakeLists.txt? They have all been created by legacy ROS tools. Some CMakeLists.txt still have conditional branches for rosbuild, which should be cleaned, too.
soem_core has been ignored and replaced by https://github.com/smits/soem a long time ago. So it is fine to leave it untouched and we can remove the folder in a follow-up PR. Or just also remove it here.
Rayman
rosbuild support has been removed with ROS indigo. So these files are not used anymore. More importantly, rosdep gets confused and loads both manifest.xml and package.xml files, and will install the wrong dependencies.