Fixed the frontend routes not being exposed

oroinc / customer-portal

OroCommerce package with customer portal and non authenticated visitor website base features.

Other

12 stars 15 forks source link

Fixed the frontend routes not being exposed #6

Closed gplanchat closed 5 years ago

gplanchat commented 5 years ago

The public/media/js/frontend_routes.js was not providing every routes, I was facing an almost empty routing list and a JS routing error.

After digging into the code, the Oro\Bundle\FrontendBundle\Extractor\FrontendExposedRoutesExtractor::isRouteExposed() wasn't exposing routes having a frontend: true without also having an exposed: true route option, which resulted in JS routing errors.

mbessolov commented 5 years ago

@gplanchat can you please describe the problem this should solve?

gplanchat commented 5 years ago

It is related to this thread in Slack, discussed with @anyt and @manowark : https://orocommunity.slack.com/archives/C11N61D1U/p1551436163008100

manowark commented 5 years ago

Can't reproduce on local environment with latest master. All route with oro_* prefix exposed automatically by next configuration https://github.com/oroinc/orocommerce-application/blob/master/config/config.yml#L74-L78. Could you please explain how I can reproduce your behavior?

anyt commented 5 years ago

Closed as no clear steps to reproduce were provided and we can't reproduce it on the latest master. Feel free to reopen when you hit the bug again with an explicit STR.