Add support for big integers to CAST function

thierrymarianne commented 3 years ago

Dear maintainers,

I've figured the CAST function does not support big int (or unsigned integers). I hope these changes could cover it.

Happy holidays!

For reference, https://dev.mysql.com/doc/refman/5.6/en/cast-functions.html https://dev.mysql.com/doc/refman/5.7/en/cast-functions.html https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html https://www.postgresql.org/docs/12/sql-expressions.html#SQL-SYNTAX-TYPE-CASTS https://www.postgresql.org/docs/9.1/datatype-numeric.html

orocla commented 3 years ago

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://oroinc.com/b2b-ecommerce/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

thierrymarianne commented 3 years ago

Good day to you all, Is there a chance that this proposal could be of some use? I wish I didn't do anything wrong ^_^

mbessolov commented 3 years ago

Hi @thierrymarianne,

My apologies, it's just been the holiday season and now busy preparing the 4.2 LTS release of Oro products.

The PR looks absolutely fine, I'll ty to merge it next week.

Sorry for the delay.

Thank you, Michael

thierrymarianne commented 3 years ago

Thank you so much @mbessolov! Cheers!

Edit I'm seeing that this PR now failed the tests... I'm going to try fix them ^_

thierrymarianne commented 3 years ago

Tests pass again 🎉

Fyi, I've used some development tooling (Docker compose configuration files and Makefile) to run the tests for postgres 9.6, mysql 8.0.3 and apply code conventions with php_codesniffer without travis.

These extra fileset could be reorganized and / or documented further so that they become useful to someone else (provided docker, docker-compose and make have been set up before).

Anyway, in a nutshell:

git cherry-pick 7fbb938f98725f85b0341b80d1fc439f8c3d5571
# copy database config before filling them out with connection credentials 
cp .env.local{.dist,}
# copy docker compose override config 
# - to pick an available network address range, 
# - to change listening ports, 
# - to enable / disable xdebug
cp docker-compose.override.yml{.dist,} 
# edit default xdebug php extension settings 
code xdebug.ini.dist 
# pull pgsql, mysql database images and build php (7.4.2) image
make build-container-images
# install vendors with composer
make install-dependencies 
# run tests for postgresql and mysql successively
make run-tests
# run php_codesniffer
make lint-code

Good luck with the LTS release!

thierrymarianne commented 3 years ago

Hey :wave:!

How is the LTS release going?

mbessolov commented 3 years ago

Merged. Thank you for the contribution!

oroinc / doctrine-extensions

Add support for big integers to CAST function #76