oroinc / doctrine-extensions

Cross database doctrine DQL functions for MySQL and PostgreSQL.
Other
317 stars 55 forks source link

Set requirement for doctrine/lexer #96

Closed alexander-schranz closed 9 months ago

alexander-schranz commented 9 months ago

The doctrine/lexer 3 is incompatible but doctrine/orm 2.18 will be using it. The doctrine/lexer was not used before 2.10 of the orm which requires dbal 2.10 that is why that requirements also. Before lexer was part of the old doctrine/common before the lexer got in its own package.

See also: https://github.com/doctrine/orm/issues/11192

alexander-schranz commented 9 months ago

@x86demon Thx for merging, do you know when the next release is planned. Would be great this is tagged before orm 2.18 is released to avoid problems if people upgrade there projects to avoid they get accidently lexer 3.

x86demon commented 9 months ago

@alexander-schranz , thank you for contribution. Tagged it as new pre-release 3.0-alpha3

alexander-schranz commented 9 months ago

Is it possible todo a 2.x release with this fix. Else doctrine/orm 2.18 would break the current stable 2.x version. If not possible it also fine then I will add a conflict on our side to doctrine/lexer 3 to avoid this problem.

x86demon commented 9 months ago

I'd prefer to keep v2 with old dependencies and limit the maximum doctrine version there to not break other project. v3 will introduce doctrine 3 support.

alexander-schranz commented 9 months ago

@x86demon thats what this pull request does :) keep things work on 2.0, avoid that doctrine/lexer 3 is installed where it does crash currently as it is not defined there:

/home/runner/work/sulu/sulu/vendor/oro/doctrine-extensions/src/Oro/ORM/Query/AST/Functions/String/GroupConcat.php:46
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:3662
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:3526
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:3491
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:2273
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:1217
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:881
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:850
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:257
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:357
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query.php:276
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query.php:288
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/AbstractQuery.php:1212
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/AbstractQuery.php:1166
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/AbstractQuery.php:913
/home/runner/work/sulu/sulu/src/Sulu/Component/Rest/ListBuilder/Doctrine/DoctrineListBuilder.php:297
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Controller/ContactController.php:340
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Controller/ContactController.php:318
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Controller/ContactController.php:262
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/HttpKernel.php:181
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/HttpKernel.php:76
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/Kernel.php:197
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/HttpKernelBrowser.php:65
/home/runner/work/sulu/sulu/vendor/symfony/framework-bundle/KernelBrowser.php:175
/home/runner/work/sulu/sulu/vendor/symfony/browser-kit/AbstractBrowser.php:385
/home/runner/work/sulu/sulu/src/Sulu/Bundle/TestBundle/Kernel/SuluKernelBrowser.php:57
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Tests/Functional/Controller/AccountControllerTest.php:1532

Using the new deps would be then in https://github.com/oroinc/doctrine-extensions/pull/97

x86demon commented 9 months ago

Thank you very much. I'll schedule the review for this week. :heavy_check_mark: - done