search

oroinc / orocommerce

Main OroCommerce package with core functionality.
http:///www.orocommerce.com/
Other
193 stars 84 forks source link

JS error while trying to Request a quote from the SL #141

Open yaroslavbr opened 3 years ago

yaroslavbr commented 3 years ago

Summary
JS error while trying to Request a quote from the SL (After update from 4.1 to 4.2).

Steps to reproduce

Actual Result Nothing happens. Error in console - app.js?version=1c451eee:180 Uncaught (in promise) Error: mediator.execute: get-line-items handler is not defined at Object.i.execute (app.js?version=1c451eee:180) at o.isConfirmationNeededFromOldShoppingList (oroshoppinglist.js?version=1c451eee:1) at o.isConfirmationNeeded (oroshoppinglist.js?version=1c451eee:1) at open (oroshoppinglist.js?version=1c451eee:1) at d.showConfirmDialog (commons.js?version=1c451eee:54) at d.<anonymous> (commons.js?version=1c451eee:54)

Expected Result
Confirmation popup should be show, no JS errors.

As I can see there is only one appearance of get-line-items in the file - https://github.com/oroinc/orocommerce/blob/4042db6d2826155b459302a7379eb3afa4b0517e/src/Oro/Bundle/ShoppingListBundle/Resources/public/js/shoppinglist-request-quote-confirmation.js#L37.

Initialization of this event was in - oro/commerce/src/Oro/Bundle/ShoppingListBundle/Resources/public/js/app/views/line-items-view.js which is removed in current version.

Details about your environment

ValeriyYustunyk commented 3 years ago

Thank you, Yaroslav. Internal ticket id: BB-20828

yaroslavbr commented 2 years ago

@ValeriyYustunyk are there any update regarding this issue?

ValeriyYustunyk commented 2 years ago

JS error should be already fixed and merged to maintenance/4.2. But if you want to add Request to quote to the shopping list dropdown, you have to implement that logic by your own.