oroinc / orocommerce

Main OroCommerce package with core functionality.
http:///www.orocommerce.com/
Other
193 stars 84 forks source link

Fix on OroPricingBundle, messages.en.yml and prices.html.twig #71

Closed mapinho closed 6 years ago

mapinho commented 6 years ago

Turn block translatable

` --- src/Oro/Bundle/PricingBundle/Resources/translations/messages.en.yml +++ vendor/oro/commerce/src/Oro/Bundle/PricingBundle/Resources/translations/messages.en.yml @@ -295,6 +295,8 @@ product_prices: empty_prices: Price not available price_not_found: Price for requested quantity is not available

` --- src/Oro/Bundle/PricingBundle/Resources/views/layouts/blank/imports/prices.html.twig +++ vendor/oro/commerce/src/Oro/Bundle/PricingBundle/Resources/views/layouts/blank/imports/prices.html.twig @@ -110,8 +110,8 @@

- - + + @@ -183,8 +183,8 @@
qtyUnit Price{{ 'oro.pricing.frontend.qty'|trans }}{{ 'oro.pricing.frontend.unit_price'|trans }}
- - + + {{ block_widget(block) }} `
orocla commented 6 years ago

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocommerce.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

mbessolov commented 6 years ago

@mapinho thank you for reporting it. The issue has been fixed, and the fix will appear in the master branch shortly, and will be included in the next release.

qtyUnit Price{{ 'oro.pricing.frontend.qty'|trans }}{{ 'oro.pricing.frontend.unit_price'|trans }}