search

oroinc / orocommerce

Main OroCommerce package with core functionality.
http:///www.orocommerce.com/
Other
193 stars 84 forks source link

0% tax resolves an order into a 500 division by 0 #81

Closed casperh1nl closed 6 years ago

casperh1nl commented 6 years ago

If there is a tax rule using 0% the orders gets thrown into a 500 error because of a division by zero bug. Added a check on the amount on tax / taxable amount.

orocla commented 6 years ago

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocommerce.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

anyt commented 6 years ago

Internal ticket id #BB-12335

anyt commented 6 years ago

merged to master (https://github.com/oroinc/orocommerce/commit/63e4df045eb57572bbe5c82c4a9aff881f69530a), thank you, @casperh1nl !