search

oroinc / platform

Main OroPlatform package with core functionality.
MIT License
629 stars 351 forks source link

feat: change utf8 to utf8mb4 encoding and utf8_bin collation to utf8mb4_bin for TranslationBundle #1002

Closed Briones closed 2 years ago

Briones commented 4 years ago

I used to have a crm-application setup with utf8 encoding and utf8_unicode_ci collation, so I recently migrate all the tables and database to utf8mb4 encoding and utf8mb4 collation, but I noticed that was an special case with oro_translation_key table that needed and special collation to be able be case sensitive, so I checked in the migration that install that table and notice that special collation using "utf8_bin", but since the rest of the tables uses utf8mb4 I'm updating the encoding and collation, keeping the special case scenario, but with utf8mb4 instead of the old utf8.

Let me know if that's okey, I tested with that collation and encoding in my own Database and seems to be working fine.

orocla commented 4 years ago

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://oroinc.com/b2b-ecommerce/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

anyt commented 4 years ago

Hi @Briones,

Thank you for your contribution! We are going to change the default encoding to utf8mb4 for the next version. Thank you for raising this question. Internal ticket id #BAP-19843