search

oroinc / platform

Main OroPlatform package with core functionality.
Other
627 stars 351 forks source link

Point configuration provider to /Resources/config/oro #1019

Closed itsekhmistro-smile closed 4 years ago

itsekhmistro-smile commented 4 years ago

Fix location directory for processes.yml config files loaded in the Workflow bundle. All /Resources/config/*/processes.yml are located in /Resources/config/oro/ Please see find . -name processes.yml.

This patch prevents oro:process:configuration:load command from failing with system error "Too many files open" due to heavy recursive directory scan.

orocla commented 4 years ago

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://oroinc.com/b2b-ecommerce/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

anyt commented 4 years ago

Hi Ivan, What OS do you use?

itsekhmistro-smile commented 4 years ago

@anyt ,

Mac OS X 

% sysctl kern.maxfiles
kern.maxfiles: 49152
% sysctl kern.maxfilesperproc
kern.maxfilesperproc: 24576

:) For sure I know that the issue could be solved by increasing the system limits. But system limit is not the root cause of the issue.

The config dir is not correct and the fix is quite obvious, isn't it?

anyt commented 4 years ago

The fact that in a core we have processes.yml files only in an oro folder doesn't mean someone else in customization hasn't added these files outside of it. It could be a huge BC break, so I can't apply it to the 4.1 branch. That's why I asked you about an OS to see is there a workaround. And as you said, on Mac you can increase the max files limit, and as I know, on Linux it's not an issue at all.

For the master branch we can fix it for sure.

itsekhmistro-smile commented 4 years ago

For the master branch we can fix it for sure.

Thank you. I'm the same with you about versioning.

Just wanna make the world a better place.

PS. On Linux it could be easily reproduced as well: bash -c "ulimit -n 1000 && bin/console ... It's just that the default values for those limits are higher on Linux than on Mac. I have a non-default value (increased one) on my Mac.