oroinc / platform

Main OroPlatform package with core functionality.
Other
627 stars 351 forks source link

BUGFIX: issue with dump translation due to method name change into \S… #1048

Closed sylvainraye closed 3 years ago

sylvainraye commented 3 years ago

…ymfony\Component\Translation\Writer\TranslationWriter

anyt commented 3 years ago

I'm closing the PR, because the following functionality was removed in 4.2 LTS, as we don't want to keep it the part of the application. See https://github.com/oroinc/platform/blob/1a1ed7f9faff484d32538ef06c090813804f0d21/incompatibilities-4-2.md#translationbundle.

sylvainraye commented 3 years ago

oh, this looks like a bad news for the Oro Deepl Integration I did !!!

mbessolov commented 3 years ago

@sylvainraye I do not see any references to the removed services in https://github.com/diglin/oro-deepl, so it does not look like your integration will be affected.

sylvainraye commented 3 years ago

oh, thank you, I wanted to check that later. You were faster. Thank you very much. I was afraid that the 4.2 may have an influence on this bundle. I will still test it to be sure but I'm glad to know that at first sight, no issue