Oro ignore-tabbable.js breaks default tab to focus behaviour

oroinc / platform

Main OroPlatform package with core functionality.

Other

627 stars 351 forks source link

Oro ignore-tabbable.js breaks default tab to focus behaviour #1062

Open jimohalloran opened 3 years ago

jimohalloran commented 3 years ago

This PR is a simple fix for #1061. Currently when ignore-tabbable.js switches focus to a new element, the contents of the new element is not highlighted breaking the default web browser behaviour.

This PR checked to see if the element just focused has a "select" method, and if so calls it to select the contents of the newly focused element. Select boxes and buttons don't have a selection and therefore we shouldn't just blindly call select() on everything.

anyt commented 3 years ago

Thank you for your contribution, @jimohalloran. The team will review your PR in the scope of the above bug fix and merge if it suits. Internal ticket id BB-20605.