oroinc / platform

Main OroPlatform package with core functionality.
MIT License
629 stars 351 forks source link

Fix incorrect namespace for UpdateEnumEntityTranslations #984

Closed ibastiaansewebmen closed 4 years ago

ibastiaansewebmen commented 4 years ago

Currently this class cannot be autoloaded, this PR should make that possible again.

rskuipers commented 4 years ago

I ran into this issue as well, thank you for fixing @ibastiaansewebmen! :+1:

anyt commented 4 years ago

Hi everyone,

Thank you, @ibastiaansewebmen, for your contribution!

Can you please, share how you have found this issue? Because our CI and local development setups haven't detected it, and we need to find this kind of issue before publishing.

ibastiaansewebmen commented 4 years ago

Hi @anyt

In one of our projects we made a translation migration and added this class as a dependency. In our CI we have phpstan running and this tried to find the class but couldn't find it because the namespace is not the same as the directory structure. Hope you have enough info for now.

anyt commented 4 years ago

Yes, it's enough. We already use phpstan for SQL injections check, so it shouldn't be hard to add one more rule there.

We'll take a look, thank you!

anyt commented 4 years ago

Merged, https://github.com/oroinc/platform/commit/48b4ec952e3f23a02187038c0799506a7d2028f7. Thank you for your contribution, @ibastiaansewebmen!