orontee / argos

Light weight front-end for Mopidy music server
GNU General Public License v3.0
19 stars 4 forks source link

Tracks are always in random order #156

Closed chrisisbd closed 6 months ago

chrisisbd commented 6 months ago

I'm running version 1.12 on an xubuntu system. When I use files/media to browse albums (one per directory) on my system the tracks always appear in random order. Is there any way to get them sorted so I can then play them in track number order?

The tracks' filenames all have the track number as the first two characters, e.g.:-

01 - Drink that Mash and Talk that Trash.flac 02 - Daddy Sang Bass.flac 03 - Yonder Stands Little Maggie.flac 04 - Micking Banjo.flac 05 - Down the Road.flac 06 - I'd Like to Have Papa Show me Around.flac 07 - The Sunny Side of the Mountain.flac 08 - Roll in my Sweet Baby's Arms.flac 09 - Flatland Two Step.flac 10 - We'll Meet Again Sweetheart.flac 11 - I'm Gonna Sleep with One Eye Open.flac

orontee commented 6 months ago

Thanks @chrisisbd for this feedback. I am a heavy user of Mopidy-Local, not Mopidy-Files; So I am not surprised that such problems exist. It should not be difficult to fix.

(...) on my system the tracks always appear in random order.

Do you mean that the order change each time you visit a given folder? Or the order change between two start of Argos? Or the order changes between two start of Mopidy?

Or the order for the tracks of a given folder is always the same but not the order you expect?

Analysis

From what I see:

Here is a screenshot:

image

After a check in the implementation, tracks being ordered by name, and track number not being taken into account is what is expected: Cf. https://github.com/orontee/argos/blob/main/argos/model/model.py#L186.

Proposal

orontee commented 6 months ago

image

orontee commented 6 months ago

@chrisisbd At first sight current implementation is ok. Let's see with time...

Will be in next release, hopefully before next year :smiley:

orontee commented 6 months ago

@chrisisbd In case you want to test it, it's available as a pre-release https://github.com/orontee/argos/releases/tag/v1.13.0-rc0

Beware that I didn't updated the application version, so it will still advertise 1.12.0...

chrisisbd commented 6 months ago

On Mon, Dec 18, 2023 at 11:01:26PM -0800, Matthias Meulien wrote:

@.*** In case you want to test it, it's available as a pre-release [2]https://github.com/orontee/argos/releases/tag/v1.13.0-rc0

Beware that I didn't updated the application version, so it will still advertise 1.12.0...

Thank you! ... and for all those messages in between. I'll download it and try it some time today, I should be able to find time.

-- Chris Green

chrisisbd commented 6 months ago

Yes, excellent, just what I want. Thank you very much. :-)

If you need any more testing etc. I'd be very happy to help. I run a mix of xubuntusystems (laptop and desktop) and sundry Raspberry Pis and Beaglebone Blacks. I'm a retired software engineer, mostly assembler and C (I started in the early 1970s). Most of my coding is in Python now though for hobby applications on the BBB and Pi.

orontee commented 6 months ago

@chrisisbd I was born in the 70s! I don't have identified important new feature to implement in Argos, and it is really stable right now, but there'll be maintenance to perform, and help is welcome for this! I've changed of job at the beginning of the month, and I guess I'll have less time left for hacking...