Add columns to error messages - Githubissues

orosmatthew / hydrogen-cpp

A hobby programming language 🔥

MIT License

391 stars 38 forks source link

Add columns to error messages #25

Open NoahGJAC opened 4 months ago

NoahGJAC commented 4 months ago

Just caught up to the latest video in the series and saw @orosmatthew wanted to but didn't implement columns. This series has been great in teaching me C++ and learn more about how compilers work.

Simple solution to add a column count to error messages that works pretty well for it's simplicity.

Changes:

Parser.hpp
- Update to display column count in error_expected() and the binding.
Tokenization.hpp
- Add a column_count int that is incremented on each consume and is reset to 1 on new lines.
- Update all token.push_backs() to include column_count

ApplePieCodes commented 2 months ago

Submit your pull request to my fork ApplePieCodes/hydrogen-cpp. The original seems to have stopped accepting them