search

orottier / web-audio-api-rs

A Rust implementation of the Web Audio API, for use in non-browser contexts
https://docs.rs/web-audio-api/
MIT License
296 stars 16 forks source link

termion does not support windows #266

Closed tasogare3710 closed 1 year ago

tasogare3710 commented 1 year ago

This dependency causes many cargo subcommands to fail on windows.

orottier commented 1 year ago

Hey @tasogare3710, thanks for flagging.

Termion is only necessary for the mic_playback example and the benchmarks example. I could move mic_playback into a different crate. That means we can drop the simplelog and textplots dependencies as well.

@b-ma what do you think about benchmarks? We could drop the interactivity right? And only leave the measurements? Or do you see value in the playback options in that file? In that case we could rewrite it to not use termion

b-ma commented 1 year ago

@b-ma what do you think about benchmarks? We could drop the interactivity right? And only leave the measurements? Or do you see value in the playback options in that file? In that case we could rewrite it to not use termion

I think it is actually quite handy to be able to ear the results (already helped me to spot huge problems while working on the perfs), maybe this could be simplified to only use std::io such as you did in the sink_id example?