orottier / web-audio-api-rs

A Rust implementation of the Web Audio API, for use in non-browser contexts
https://docs.rs/web-audio-api/
MIT License
300 stars 16 forks source link

Fix: prevent `AudioBufferSourceNode` to restart when loop is set to true #521

Closed b-ma closed 2 months ago

b-ma commented 2 months ago

This fixes https://github.com/ircam-ismm/node-web-audio-api/issues/135 and maybe https://github.com/ircam-ismm/node-web-audio-api/issues/134 (TBC)

There are new unrelated clippy issues that I didn't fixed, mostly small doc things but one that concerns transmute that I think it is better that you check, let's do that in another PR?

orottier commented 2 months ago

Ah I realize you lag behind the main branch, could you merge it in? CI/clippy was already fixed

b-ma commented 2 months ago

Ah I realize you lag behind the main branch, could you merge it in? CI/clippy was already fixed

Damn, sure I'll fix that