search

orphan-oss / launch4j-maven-plugin

A Maven plugin which wraps Launch4j
Other
368 stars 71 forks source link

Rebuilding, custom repo, two machines (including fix) #336

Open Lilianne-Blaze opened 10 months ago

Lilianne-Blaze commented 10 months ago

There are some problems with rebuilding the plugin. First, if you have a custom versions of both the plugin and Launch4j and you upload it to your own repo, then try to build a simple demo on another machine it doesn't recognize Launch4j from custom repo. It's there on the disk, but gets ignored. Second, the LocalArtifactResult.getFile() returns expanded versions, contrary to the comments. I assume it was a bug in Maven that got fixed in the meantime. It resulted in Launch4j being unable to locate one of the exe files.

Here are the quick fixes for both https://github.com/Lilianne-Blaze/lbfork-launch4j-maven-plugin/commit/7088cf462d576f51457431774958d87c0b09fa96 The relevant parts are in Launch4jMojo unpackWorkDir lines 546-628

The tests were on Maven 3.9.1, Liberica JDK 21, Windows 11/10.

lukaszlenart commented 10 months ago

Would you mind opening a PR with your change?

Lilianne-Blaze commented 10 months ago

Added some changes so both fixes run only if previous code failed https://github.com/orphan-oss/launch4j-maven-plugin/pull/337/commits/2843be05f0aba918f3202818e90210691c2cb3a2