search

orphu / mcdungeon

A procedural dungeon generator for Minecraft
Other
84 stars 18 forks source link

Update entity building functions for 1.11/1.12 and make case-insensitive. #392

Closed JiFish closed 7 years ago

JiFish commented 7 years ago

Update entity building functions for 1.11/1.12 and make case-insensitive. Currently this isn't breaking anything, but needs to be fixed for future use.

JiFish commented 7 years ago

To eliminate the risk of someone repeating what I have already done, I have pushed my changes so far to an alternate branch. This code needs way more testing than I have currently put it through.

orphu commented 7 years ago

I've merged this into development to continue. I think this needs to be in the next release.

JiFish commented 7 years ago

Thanks for picking this up. Unfortunately, I simply didn't have the time to give this the proper testing it needed.

This may potentially fix #403

orphu commented 7 years ago

Hm, maybe. Right now spawners aren't generated by this code, but they could be. At the moment it's all handled with addspawner() and getspawnertags() in deungeon.py. Could (and probably should) move getspawnertras() into this code.

Would be nice if we could store NBT files as text to make them easier to deal with. #362 sounds problematic though. Maybe YAML instead of JSON...

JiFish commented 7 years ago

Is this complete?

orphu commented 7 years ago

I need to go through the recent release notes and make sure it's all covered.