search

orphu / mcdungeon

A procedural dungeon generator for Minecraft
Other
84 stars 18 forks source link

Banners Base Colour is always black when it is an item reward. #397

Closed ninmore closed 7 years ago

ninmore commented 7 years ago

When you generate a banner for a dungeon when the banner is placed in the dungeon such as in the secret shop or church room it is the correct base colour. But when the banner is an item reward in chests the base colour is always black. Here is a picture of the items, left is secret shop banner and the on the right it is wrong, the item drop one http://bit.ly/2kdKksK

And item details: http://bit.ly/2kdBzPe http://bit.ly/2kdL8hm

JiFish commented 7 years ago

Thanks for the detailed report. I can confirm this bug.

Either flag items store the background differently from flag entities, or I missed something in the last update.

JiFish commented 7 years ago

Interesting, setting the damage value on the item is necessary, but not on the entity. I wonder why Mojang did it this way? At any rate, I should be able to fix it.

Edit: But setting the value on shields will cause them to be almost broken when found. Hmmm...

JiFish commented 7 years ago

Fixed in development version and next release.