search

orppst / pst-gui

web based front end for the tool
Mozilla Public License 2.0
0 stars 0 forks source link

On initial render, user is "Unknown". #107

Closed DJWalker42 closed 6 months ago

DJWalker42 commented 6 months ago

The only button that then gets the AppShell to re-render with the correct username is the light-dark mode toggle switch. Having "unknown" as the user causes problems when trying to create a new proposal as the Person is then not known.

pahjbo commented 6 months ago

I am not seeing this - can you make it happen reliably?

DJWalker42 commented 6 months ago

Yep. The first image is immediately after logging in, the second is after clicking the 'light/dark' mode toggle:

user_unknown user_PI

I should add I'm using Chrome but I also see this issue in Safari.

pahjbo commented 6 months ago

Firefox is the same as Chrome, in that it shows "unknown" every time - I think that the App2.tsx code might benefit from being broken up into several components - it might then be clearer what is happening - it is nice style to have the return of the component at the end of the file which is not the case here - there also could be some subtle closure effects going on with the functions defined in other functions...

pahjbo commented 6 months ago

it also seems that on firefox and chrome - logging out does not completely log the person out like it does on safari