search

orppst / pst-gui

web based front end for the tool
Mozilla Public License 2.0
0 stars 0 forks source link

105 focus ring on navbar items is clipped #110

Closed DJWalker42 closed 3 months ago

DJWalker42 commented 3 months ago

That was a journey for something relatively simple. Turns out trying to use nested maps has issues. Anyway, NavLinks for proposals now reside in an Accordion and will be highlighted when selected.

I have also fixed the scroll-ability issue. It looks like the 'Grid' element was blocking the scrollable functionality of the 'AppShell.Section'.

DJWalker42 commented 3 months ago

Allan wrote (in the wrong PR comment section so quoting here):

There's a odd re-rendering of the whole accordion when I change what's selected, but in terms of the highlighting and scrolling this is a big improvement.

The re-rendering seems to be when the result of the "GetProposals" fetch is loading meaning it seems to be re-rendering the entire page when clicking through the NavLinks, which is not ideal but I'll say is liveable for now. Please don't remind me of this comment when it comes back at us as a performance issue.

DJWalker42 commented 3 months ago

Now that you've pointed out the re-rendering, I'm not happy with it, so putting this as a draft PR for now.

DJWalker42 commented 3 months ago

The re-render is the Accordion only, not the entire page, still though it needs re-thinking

DJWalker42 commented 3 months ago

Found it! I was not putting hooks in the right place.